feat: implement validate on blur & input #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skaiir
force-pushed
the
382-validate-on-blur
branch
from
0155a98
to
5a9c2f7
Compare
bpmn-io-tasks
bot
added
needs review
|
Rebased to develop, surprisingly went very smoothly despite 200 commits behind :D |
|
I will have a deeper look at this tomorrow 👍 @christian-konrad @RomanKostka feel free to have a look at this as well, as this quite a change in the validation flow. https://demo-382-validate-on-blur--camunda-form-playground.netlify.app/ |
packages/form-js-viewer/src/features/viewerCommands/behaviors/index.js
Outdated
Show resolved
Hide resolved
Skaiir
force-pushed
the
382-validate-on-blur
branch
from
5a9c2f7
to
098c2d6
Compare
Skaiir
force-pushed
the
382-validate-on-blur
branch
from
098c2d6
to
ca576b0
Compare
pinussilvestrus
approved these changes
Jul 27, 2023
nikku
reviewed
Aug 7, 2023
| } | ||
|
|
||
| registerHandlers() { | ||
| Object.entries(this.getHandlers()).forEach(([ id, handler ]) => { |
There was a problem hiding this comment.
I found the usage of CommandStack in the viewer context interesting here. Just to better understand what is happening, why did we add it? Is undo/redo a needed capability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382
Closes #323
Demo: https://demo-382-validate-on-blur--camunda-form-playground.netlify.app/